Remove image downsampling from IMAT endpoint#344
Closed
Conversation
Stop downsampling IMAT images and simplify image conversion plumbing. The GET /imat/latest-image endpoint no longer accepts or uses a downsample_factor and now returns full-resolution RGB bytes with shape [height, width, 3]. The image_service.convert_image_to_rgb_array signature was simplified to return (data, width, height) and all resizing logic was removed. Router imports and payload fields related to original/sampled dimensions and downsampleFactor were removed, and tests were updated to match the new full-resolution behavior (including removal of the downsampling unit test).
There was a problem hiding this comment.
Pull request overview
This PR removes downsampling support from the plotting-service IMAT “latest image” flow and updates tests to reflect the simplified response contract.
Changes:
- Simplifies
GET /imat/latest-imageto removedownsample_factorand return onlydataandshape. - Refactors
convert_image_to_rgb_arrayto always return full-resolution RGB data plus dimensions. - Updates plotting-service tests to validate the new helper signature and endpoint payload.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| plotting-service/plotting_service/routers/imat.py | Removes the downsample query param and trims response payload to data + shape. |
| plotting-service/plotting_service/services/image_service.py | Simplifies image conversion helper to full-resolution output and updates return signature. |
| plotting-service/test/test_plotting_api.py | Updates/cleans tests for new helper signature and latest-image response shape. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
58
to
68
| # Convert the image to RGB array | ||
| try: | ||
| data, original_width, original_height, sampled_width, sampled_height = convert_image_to_rgb_array( | ||
| latest_path, downsample_factor | ||
| ) | ||
| data, width, height = convert_image_to_rgb_array(latest_path) | ||
| except Exception as exc: | ||
| logger.error("Failed to convert IMAT image at %s", latest_path, exc_info=exc) | ||
| raise HTTPException(HTTPStatus.INTERNAL_SERVER_ERROR, "Unable to convert IMAT image") from exc | ||
|
|
||
| # Calculate effective downsample factor | ||
| effective_downsample = original_width / sampled_width if sampled_width else 1 | ||
|
|
||
| payload = { | ||
| "data": data, | ||
| "shape": [sampled_height, sampled_width, 3], | ||
| "originalWidth": original_width, | ||
| "originalHeight": original_height, | ||
| "sampledWidth": sampled_width, | ||
| "sampledHeight": sampled_height, | ||
| "downsampleFactor": effective_downsample, | ||
| "shape": [height, width, 3], | ||
| } |
There was a problem hiding this comment.
/imat/latest-image now always returns full-resolution pixel data as a JSON list of ints. Compared to the previous default downsample (8x), this can increase response size and server memory/CPU significantly for typical IMAT images; consider adding a hard cap/alternative encoding (e.g., base64 bytes) or explicitly documenting/guarding the maximum supported image dimensions.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/fiaisis/plotting-service/sessions/d7f9bd2a-5dd3-477c-bfb0-66c6e4e90105 Co-authored-by: Dagonite <47388695+Dagonite@users.noreply.github.com>
Copilot
AI
changed the title
Remove image downsampling from IMAT endpoint
Fix docstring for Apr 9, 2026
convert_image_to_rgb_array and test naming
Dagonite
changed the title
convert_image_to_rgb_array and test naming
Collaborator
Author
|
Closing for now as IMAT Stack Viewer still uses this logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #296.
Description
Removes unused downsampling support from the IMAT latest-image flow and aligns the frontend with the simplified API contract.
Testing