fix(slideOnTouch): slideOnTouch not changes images on mobile devices#572
Open
SinnerAir wants to merge 7 commits intofengyuanchen:mainfrom
Open
fix(slideOnTouch): slideOnTouch not changes images on mobile devices#572SinnerAir wants to merge 7 commits intofengyuanchen:mainfrom
SinnerAir wants to merge 7 commits intofengyuanchen:mainfrom
Conversation
On mobile devices, you can't swipe through the images
Owner
|
Are you sure this change is helpful? |
Author
|
Yes, on mobile you can't slide images right now. I checked on Android. |
Owner
|
Work fine in Safari or Chrome for iOS, may need to check in Chrome for Android later. |
Author
|
My device: |
… данная опция задана
# Conflicts: # dist/viewer.common.js # dist/viewer.css # dist/viewer.esm.js # dist/viewer.js # dist/viewer.min.css # dist/viewer.min.js # docs/css/viewer.css # docs/js/viewer.js # package-lock.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On mobile devices, you can't swipe through the images
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of the default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: