Skip to content

docs: highlight !IMPORTANT flags correctly#985

Merged
pydanny merged 1 commit intofeldroy:mainfrom
garzuze:docs-fixes
Jan 12, 2026
Merged

docs: highlight !IMPORTANT flags correctly#985
pydanny merged 1 commit intofeldroy:mainfrom
garzuze:docs-fixes

Conversation

@garzuze
Copy link
Contributor

@garzuze garzuze commented Jan 9, 2026

Summary

Two !IMPORTANT flags where not being rendered correctly because there was a ">" missing or they where inside another quote block.

Issue(s)

Not related to any issue.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature
    • Core Air (Air Tags, Request/Response cycle, etc)
    • Optional (Authentication, CSRF, etc)
    • Third-Party Integrated (Cookbook documentation on using Air databases or a task manager, etc)
    • Out-of-Scope (Formal integration with databases, external task managers, or commercial services etc - won't be accepted, please create a separate project)
  • Refactoring (no functional changes, no api changes)
  • Chore: Dependency updates, Python version changes, etc.
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Pull request tasks

The following have been completed for this task:

  • Code changes
  • Documentation changes for new or changed features
  • Alterations of behavior come with a working implementation in the examples folder
  • Tests on new or altered behaviors

Checklist

  • I have run just test and just qa, ensuring my code changes passes all existing tests
  • I have performed a self-review of my own code
  • I have ensured that there are tests to cover my changes

@garzuze garzuze marked this pull request as draft January 9, 2026 14:55
@garzuze garzuze marked this pull request as ready for review January 9, 2026 15:01
@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Member

@pydanny pydanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @garzuze, thanks for the PR! Can you run just qa locally, address any issues, and push up the changes? Thanks!

Copy link
Member

@pydanny pydanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another documentation PR we're working on. We'll handle the linting there.

@pydanny pydanny merged commit 980d94b into feldroy:main Jan 12, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants