Convert to ESM #151
Merged
Convert to ESM #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency is removed and _.pull() is replaced with Array splice(), and _.assignIn() is replaced with Object.assign().
Updates dependencies and modernizes code to use native ES modules and Node.js built-ins. Removes CoffeeScript and config-chain dependencies.
- add `.js` esxtention to module names - add chain to server start, as it is now async!
Member
Author
|
This version is available for installing as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next step of updating the server code.
Includes ESM version of wiki-server - fedwiki/wiki-server#202
As this version also cuts the last tie with CoffeeScript, any server plugin that still need CoffeeScript will need to add it as one of their dependencies. Both the security plugins are still written in CoffeeScript, so there is a PR for both of them. fedwiki/wiki-security-friends#18 and fedwiki/wiki-security-passportjs#50
This PR also includes #148