Fix an assumption that C’s char type is signed#161
Merged
jeremycline merged 1 commit intofedora-infra:mainfrom Mar 19, 2026
Merged
Fix an assumption that C’s char type is signed#161jeremycline merged 1 commit intofedora-infra:mainfrom
jeremycline merged 1 commit intofedora-infra:mainfrom
Conversation
Member
|
Thanks for the fix! If you don't mind signing off your commit, I'm happy to take this. |
This fixes failure of siguldry-pkcs11 to build on most common architectures other than x86_64. Signed-off-by: Benjamin A. Beasley <code@musicinmybrain.net>
Contributor
Author
Done! Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes failure of
siguldry-pkcs11to build on many 64-bit architectures other thanx86_64. (32-bit architectures have bigger problems, but thanks to https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval we don’t need to care about this in Fedora.)I’m planning to bring this up in the downstream package review. I used a scratch build of that submission to confirm that this change fixes failure to build on
aarch64,ppc64le, ands390x.