Allow querying updates by side tag name#6078
Open
nforro wants to merge 1 commit intofedora-infra:developfrom
Open
Allow querying updates by side tag name#6078nforro wants to merge 1 commit intofedora-infra:developfrom
nforro wants to merge 1 commit intofedora-infra:developfrom
Conversation
Packit allows to automate creating multi-package updates by using side tags. However, since the lifecycle of a side tag doesn't necessarily correspond to the lifecycle of the update created from it, it is necessary for Packit, as side tag creator, to be able to query updates corresponding to a particular side tag so that it can act accordingly when an update has been obsoleted or unpushed. In order not to break existing API, this commit adds a new field, `from_side_tag_name`, that allows to query for updates created from the specified side tag. Alternatively, the existing `from_side_tag` field could be adjusted to accept both a boolean value and a string, but I'm not sure that's such a good idea. Signed-off-by: Nikola Forró <nforro@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packit allows to automate creating multi-package updates by using side tags. However, since the lifecycle of a side tag doesn't necessarily correspond to the lifecycle of the update created from it, it is necessary for Packit, as side tag creator, to be able to query updates corresponding to a particular side tag so that it can act accordingly when an update has been obsoleted or unpushed.
In order not to break existing API, this commit adds a new field,
from_side_tag_name, that allows to query for updates created from the specified side tag.Alternatively, the existing
from_side_tagfield could be adjusted to accept both a boolean value and a string, but I'm not sure that's such a good idea.