Support multiple destination registries#6077
Support multiple destination registries#6077Zlopez wants to merge 2 commits intofedora-infra:developfrom
Conversation
With the move of flatpaks from registry.fedoraproject.org to quay.io (see https://forge.fedoraproject.org/infra/tickets/issues/11543 for more details) we want the bodhi to support uploading to multiple registries. This PR changes the container.destination_registry to list and when copying from candidate registry it copies to all the destinations. Signed-off-by: Michal Konecny <mkonecny@redhat.com>
|
I think this is ready for review now. I can see the integration tests are failing on the same issue in other PRs as well and the readthedocs build seems completely unrelated to the changes. |
bodhi-server/bodhi/server/config.py
Outdated
| 'container.destination_registry': { | ||
| 'value': 'registry.fedoraproject.org', | ||
| 'validator': str}, | ||
| 'value': ['registry.fedoraproject.org', 'quay.io/fedora/flatpak'], |
There was a problem hiding this comment.
Production bodhi configuration in ansible just uses the defaults, so I'm unsure if we want to change these... maybe it's better to just change the value to a list with only registry.fp.o.
For staging bodhi the value is set to
{% if env == 'staging' %}
container.destination_registry = registry.stg.fedoraproject.org
container.source_registry = candidate-registry.stg.fedoraproject.org
{% endif %}
shall we use 'quay.io/fedora/flatpak' or is there any staging destination?
There was a problem hiding this comment.
There is a staging target quay.io/fedora-testing/flatpak, I can use this.
news/PR6077.feature
Outdated
| @@ -0,0 +1 @@ | |||
| Support multiple destination registries for containers | |||
There was a problem hiding this comment.
better use the suffix .bic (backward incompatible change) for the file and specify in the notes that the container.destination_registry setting can now be specified as whitespace separated list of values
There was a problem hiding this comment.
Will do, it makes sense.
* Only use registry.fedoraproject.org for default config * Mark the change as backwards incompatible and add note Signed-off-by: Michal Konecny <mkonecny@redhat.com>
2 participants
With the move of flatpaks from registry.fedoraproject.org to quay.io (see https://forge.fedoraproject.org/infra/tickets/issues/11543 for more details) we want the bodhi to support uploading to multiple registries.
This PR changes the container.destination_registry to list and when copying from candidate registry it copies to all the destinations.