docs(odfv): document column naming behavior when using multiple FeatureView sources#6087
Open
anix-lynch wants to merge 1 commit intofeast-dev:masterfrom
Open
docs(odfv): document column naming behavior when using multiple FeatureView sources#6087anix-lynch wants to merge 1 commit intofeast-dev:masterfrom
anix-lynch wants to merge 1 commit intofeast-dev:masterfrom
Conversation
…rces Signed-off-by: Ani Lynch <anixlynch@gmail.com>
c0f078c to
20302ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The ODFV docs only show examples with a single
FeatureView+RequestSourcecombination, where columns are accessed by feature name directly (e.g.,features_df["conv_rate"]).What's not documented: when multiple FeatureViews are passed as sources, Feast prefixes each column with
{feature_view_name}__to avoid naming conflicts. This causes a silentKeyErrorwhen users tryfeatures_df["conv_rate"]expecting the behavior shown in the docs.Real-world failure
Building an ODFV with two FeatureView sources:
Actual column name at runtime:
customer_transaction_features__recency_daysNothing in the docs explains this prefix behavior.
Fix
Added a Column Naming in the Input DataFrame section with:
Changes
docs/reference/beta-on-demand-feature-view.md— new section before CLI Commands