fix: Fix non-specific label selector on metrics service#6067
Merged
ntkathole merged 1 commit intofeast-dev:masterfrom Mar 9, 2026
Merged
fix: Fix non-specific label selector on metrics service#6067ntkathole merged 1 commit intofeast-dev:masterfrom
ntkathole merged 1 commit intofeast-dev:masterfrom
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
astefanutti
reviewed
Mar 5, 2026
| spec: | ||
| selector: | ||
| matchLabels: | ||
| control-plane: controller-manager |
There was a problem hiding this comment.
That's also a problem here. We need to be careful for the upgrade path.
Member
Author
There was a problem hiding this comment.
yes, it's not added there due to upgrade failure. It's immutable. But it doesn't cause the bug.
Member
Author
There was a problem hiding this comment.
Added, and documented the upgrade path
ntkathole
force-pushed
the
fix_labels
branch
3 times, most recently
from
64b41c1 to
c48a5ee
Compare
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
feast-operator-controller-manager-metrics-serviceuses a non-specific label selector (control-plane: controller-manager) that matches pods from any operator using the standard kubebuilder scaffolding label. In shared-namespace environments, where multiple operators are deployed in the same namespace, this causes the Service to incorrectly select pods belonging to other operators.Added
app.kubernetes.io/name: feast-operatorto all selectors and pod template labels so that the metrics Service, Deployment, and ServiceMonitor uniquely identify Feast operator pods.