docs: Explain why event_timestamp is required in entity_df#6038
Open
Br1an67 wants to merge 1 commit intofeast-dev:masterfrom
Open
docs: Explain why event_timestamp is required in entity_df#6038Br1an67 wants to merge 1 commit intofeast-dev:masterfrom
Br1an67 wants to merge 1 commit intofeast-dev:masterfrom
Conversation
Expand the Event timestamp section in the feature retrieval concepts page to explain: - Why event_timestamp is required in the entity dataframe - How point-in-time joins work (last known good value temporal join) - How this prevents data leakage during model training - A concrete example illustrating the behavior Also add inline comments in the quickstart code example.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Expands the "Event timestamp" section in the feature retrieval concepts page to explain:
event_timestampis required in the entity dataframe passed toget_historical_features()Also adds inline comments in the quickstart code example to clarify the role of
event_timestamp.Which issue(s) this PR fixes:
Fixes #5555
Misc
Documentation-only change (2 files:
docs/getting-started/concepts/feature-retrieval.mdanddocs/getting-started/quickstart.md).