fix: Make feature server URL configurable#6020
Open
kchawlani19 wants to merge 1 commit intofeast-dev:masterfrom
Open
fix: Make feature server URL configurable#6020kchawlani19 wants to merge 1 commit intofeast-dev:masterfrom
kchawlani19 wants to merge 1 commit intofeast-dev:masterfrom
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
kchawlani19
changed the title
kchawlani19
force-pushed
the
fix/feature-server-url
branch
from
3082026 to
b641677
Compare
ntkathole
changed the title
Signed-off-by: kchawlani19 <kchawlan@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
ntkathole
force-pushed
the
fix/feature-server-url
branch
from
b641677 to
c3ea607
Compare
ntkathole
reviewed
Feb 25, 2026
| <EuiFieldText | ||
| value={serverUrl} | ||
| onChange={(e) => setServerUrl(e.target.value)} | ||
| placeholder="http://localhost:6566" |
Member
There was a problem hiding this comment.
need to change placeholder as well
ntkathole
reviewed
Feb 25, 2026
| feastObjectQuery, | ||
| }: RegularFeatureViewCustomTabProps) => { | ||
| const data = feastObjectQuery.data as any; | ||
| const defaultServerUrl = |
Member
There was a problem hiding this comment.
I think it could be a module-level constant, declaring it inside the component means it gets re-evaluated on every render
Member
|
Can we also add the documentation ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan