This repository was archived by the owner on Jan 3, 2019. It is now read-only.
Connection problem (partial) fix#80
Open
hading wants to merge 1 commit intofcrepo4-archive:masterfrom
Open
Conversation
Release connections after they are used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make limits on maximum number of connections in pool.
Release connections after they are used.
This is regarding #79.
It's not fully complete. The limits on the connection pool are currently just magic numbers; I assume you'd want to work that into configuration in whatever standard way you have of doing it.
The tests pass at this point, and the connections do not pile up.
I do, however (as noted in the JIRA ticket) now experience some items not being indexed. I don't know if this is because of problems in my code or if messages are being dropped somehow. I don't tend to see it until I start indexing around 5000-10000 things or so all at once.
I don't know if I'll look further - it's been suggested that we look into using the Camel integration instead. But since I already had this might as well send it along.