Persist jcr/xml in hierarchy structure.#49
Persist jcr/xml in hierarchy structure.#49lsitu wants to merge 1 commit intofcrepo4-archive:masterfrom
Conversation
There was a problem hiding this comment.
These parameters are too complicated and redundant: baseURL and baseURL + id
|
This implementation creates the following directories: The directory should start at "collection" |
|
Okay, I've rebase and squash it into one commit lsitu@4274f9f. The compiling error/conflicts should be fixed now. |
There was a problem hiding this comment.
"parent" should actually be "parentID", no?
When the index() call concatenates "baseURL" and "parent" it should have a valid URI.
Should this instead be:
final String parentID = uri.substring(uri.lastIndexOf("/"));
There was a problem hiding this comment.
@awoods It sounds good to me. The term "parent" was used that way in the source codes. Would you like me to make the change now?
There was a problem hiding this comment.
@lsitu, it is not just the name of the variable, but the logic in creating the substring that likely needs to change.
I believe the current logic is incorrect.
|
I've updated it to use the parentID and made the change to use reindexURI( child, "", true ) instead of splitting the child url into two parts like baseURL+id. |
https://www.pivotaltracker.com/s/projects/684825/stories/75644184