fix: layer editor toolbar below modals#5082
Conversation
✅ Deploy Preview for char-cli-web canceled.
|
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for unsigned-char ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for fastrepl ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Lower the editor format toolbar z-index so floating chat and modal surfaces stay above it.
ComputelessComputer
force-pushed
the
fix/bubble-menu-modal-layer
branch
from
ab1372e to
701a2c3
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 701a2c3. Configure here.
| "shadow-[0_0_0_1px_rgba(0,0,0,0.05),0_6px_12px_-3px_rgba(0,0,0,0.08)]", | ||
| ])} | ||
| style={{ top: 0, left: 0 }} | ||
| style={{ position: "fixed", top: 0, left: 0 }} |
There was a problem hiding this comment.
Redundant inline position: "fixed" duplicates Tailwind class
Low Severity
The inline style sets position: "fixed" while the className already includes the Tailwind fixed utility, which applies the same CSS property. No other component in the codebase combines both. This redundancy could confuse future maintainers if one declaration is updated without the other, creating a subtle inconsistency risk.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 701a2c3. Configure here.
1 participant
Lower the editor format toolbar z-index so floating chat and modal surfaces stay above it.
Note
Low Risk
UI-only change to the editor floating toolbar’s positioning/portal target; main risk is minor regressions in toolbar placement or visibility in edge cases (selection, scrolling, SSR).
Overview
Adjusts the editor
FormatToolbaroverlay so it no longer sits above modal/chat surfaces by lowering its stacking context (z-30) and switching fromabsolutetofixedpositioning.Updates Floating UI positioning to use
strategy: "fixed", and renders the portal into#root(falling back todocument.body) with an SSR-safedocumentguard to avoid crashes whendocumentis unavailable.Reviewed by Cursor Bugbot for commit 701a2c3. Bugbot is set up for automated code reviews on this repo. Configure here.