Conversation
✅ Deploy Preview for char-cli-web canceled.
|
✅ Deploy Preview for unsigned-char ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote canceled.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a7ae905. Configure here.
| } else if (payload.type === "micStopped") { | ||
| stop(); | ||
| setMicStoppedPending(true); | ||
| windowsCommands.windowShow({ type: "main" }); |
There was a problem hiding this comment.
Missing active session guard for micStopped event handler
Medium Severity
The micStopped event handler sets micStoppedPending to true and shows the main window without checking whether Hypr has an active recording session. The detect plugin fires micStopped at the system level whenever any meeting app releases the mic — independent of Hypr's state. Previously, calling stop() was a harmless no-op when no session was active. Now it results in a confusing "Is your meeting over?" prompt even when the user never started recording. The micDetected handler already has a live.status === "active" guard for exactly this reason, but the micStopped handler lacks an equivalent check.
Reviewed by Cursor Bugbot for commit a7ae905. Configure here.
| onClick={() => { | ||
| stop(); | ||
| setMicStoppedPending(false); | ||
| }} |
There was a problem hiding this comment.
Stale micStoppedPending flag can stop a subsequent session
High Severity
micStoppedPending is only cleared by the MeetingOverCTA buttons ("Yes"/"No"). If the session stops through any other path — the header "Stop" button, a sleepStateChanged event, or an error — the flag stays true. When the user later starts a new session, the stale CTA appears, and clicking "Yes" calls stop() on the new session, terminating it unexpectedly. The flag needs to be cleared whenever the live session transitions to inactive (e.g., in markLiveInactive or equivalent).
Additional Locations (1)
Reviewed by Cursor Bugbot for commit a7ae905. Configure here.
1 participant
No description provided.