handle path same as when uploading apk#102
Open
davibe wants to merge 1 commit intofastlane-community:masterfrom
Open
handle path same as when uploading apk#102davibe wants to merge 1 commit intofastlane-community:masterfrom
davibe wants to merge 1 commit intofastlane-community:masterfrom
Conversation
joshdholtz
reviewed
Aug 17, 2021
Member
joshdholtz
left a comment
joshdholtz
left a comment
There was a problem hiding this comment.
@davibe Thanks for the PR! I'm actually not sure what the issue was here that this is fixing 🤔
Was the issue that the url was getting a double / appended to it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at the issue and the commit should be quite clear.
However, note that I tested this for Android and I assumed that iOS uploading works the same as the APK. File uploading is a common feature across iOS and Android obviously.