Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
commented
Apr 19, 2025
| /// | ||
| /// By default, this function returns a future that never resolves, i.e., the action will never | ||
| /// be shutdown. | ||
| fn is_shutdown(&self) -> impl Future<Output = ()> + Send { |
Contributor
Author
There was a problem hiding this comment.
No shutdown in Action since lieftime is tricky to handle. Follow axum's and poem's practice to pass a shutdown future that resolved to signal the action to shutdown.
I'd prefer to use a closure for geenrate the future each time but FnMut would face the issue as described in https://docs.rs/backon/latest/backon/trait.RetryableWithContext.html#example. And AsyncFnMut would hit the issue in rust-lang/rust#62290 (comment).
tisonkun
commented
Apr 19, 2025
| } | ||
|
|
||
| /// A teardown hook that is called when the action is shutdown. | ||
| fn teardown(&mut self) {} |
Contributor
Author
There was a problem hiding this comment.
Sync teardown can be implemented in Action's Drop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.