Skip to content

chore(deps): bump rust from 1.89 to 1.95#799

Open
dependabot[bot] wants to merge 4 commits intomainfrom
dependabot/docker/rust-1.95
Open

chore(deps): bump rust from 1.89 to 1.95#799
dependabot[bot] wants to merge 4 commits intomainfrom
dependabot/docker/rust-1.95

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Apr 24, 2026

Bumps rust from 1.89 to 1.95.

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file docker Pull requests that update docker code labels Apr 24, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
snapchain-docs Ready Ready Preview, Comment Apr 24, 2026 2:53pm

Request Review

@github-actions
Copy link
Copy Markdown

Diff Coverage

Diff: origin/main...HEAD, staged and unstaged changes

No lines with coverage information in this diff.

Bumps rust from 1.89 to 1.95.

---
updated-dependencies:
- dependency-name: rust
  dependency-version: '1.95'
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/docker/rust-1.95 branch from f3aa461 to 4146b15 Compare April 24, 2026 03:41
@manan19 manan19 requested review from Copilot and topocount and removed request for topocount April 24, 2026 13:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Rust toolchain used by the Docker build to a newer Rust release, keeping the containerized build environment current.

Changes:

  • Bump the Rust Docker base image from rust:1.89 to rust:1.95.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Dockerfile
@@ -1,4 +1,4 @@
FROM rust:1.89 AS chef
FROM rust:1.95 AS chef
Keeps CI and the Docker build on the same Rust version so PRs
can't pass CI while breaking the Docker build (or vice versa).

Addresses Copilot review comment on #799.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@manan19
Copy link
Copy Markdown
Contributor

manan19 commented Apr 24, 2026

Rust 1.89 → 1.95 bump analysis

Safety assessment

Likely safe to merge. No MSRV is pinned in Cargo.toml (no rust-version field) and there's no rust-toolchain.toml, so the only places the toolchain is declared are the Dockerfile and .github/workflows/verify-impl.yml. Rust's strong backward-compat guarantees across minor releases mean semantic breakage over 1.90–1.95 is very unlikely; the main realistic risk is new lints firing under CI's RUSTFLAGS="-Dwarnings".

I ran cargo check --all-targets locally with Rust 1.95.0 and the same RUSTFLAGS="-Dwarnings -A mismatched_lifetime_syntaxes" CI uses. Most workspace crates compiled cleanly with zero rustc warnings before the check hit an unrelated local env issue (jemalloc's configure script doesn't like spaces in my checkout path). No new-lint regressions surfaced in the portion that did compile.

Addressed Copilot's comment

Copilot correctly flagged that the Docker image was being bumped to 1.95 while .github/workflows/verify-impl.yml still pinned 1.89.0 — that kind of skew means CI could pass on a version that doesn't match what the Docker build uses. I pushed a commit to this branch bumping CI to 1.95.0 as well so both stay aligned.

Additional observations (not blocking)

  • There's a secondary CI gap worth noting separately: .github/workflows/verify.yml's paths-filter for the code label doesn't include Dockerfile, so a pure Dockerfile change wouldn't run the test job. This PR dodges that because it now also touches verify-impl.yml, which is in the filter. Might be worth adding Dockerfile to verify.yml's filter in a follow-up so future Dockerfile-only bumps still exercise the Rust test suite.
  • Longer-term, adding a rust-toolchain.toml as the single source of truth (consumed by both the Dockerfile and CI) would prevent this skew from reappearing — the current two-location setup is the kind of thing Dependabot will keep getting half-right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file docker Pull requests that update docker code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants