Update rocksdb (previously pinned ref included in a release)#646
Open
mehcode wants to merge 1 commit intofarcasterxyz:mainfrom
Open
Update rocksdb (previously pinned ref included in a release)#646mehcode wants to merge 1 commit intofarcasterxyz:mainfrom
mehcode wants to merge 1 commit intofarcasterxyz:mainfrom
Conversation
Signed-off-by: Ryan Leckey <ryan@calaxy.com>
|
@mehcode is attempting to deploy a commit to the farcaster Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Looks like this was the original reason for pinning this version #16 (comment). Thanks. This requires some testing to make sure everything is backwards compatible. We'll merge when we have some time to verify. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The currently pinned commit rev was included in release 0.23 of
rocksdb. Assuming this passes CI, this seems safe to merge.I updated this all the way to 0.24 as 0.23 does not build on my fresh Arch linux machine (build issues with 0.20 llvm/clang).