fix(deps): update symfony packages to v8 (major)#369
Conversation
|
Pull Request Review: Symfony 8.0 UpgradeOverviewThis PR upgrades all Symfony components from ^7.1 to ^8.0. This is a major version upgrade generated by Renovate bot. ✅ Positive Aspects
|
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
from
9887841 to
c9a3c8b
Compare
PR Review: Symfony 8.0 UpgradeThank you for this automated dependency upgrade! Here's my analysis: 🔍 OverviewThis PR upgrades 15 Symfony packages from
|
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
from
c9a3c8b to
a4cbef5
Compare
Pull Request Review: Symfony 8.0 UpgradeOverviewThis PR upgrades all Symfony components from ✅ Positive Aspects
|
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
from
a4cbef5 to
83911ee
Compare
PR Review: Symfony 8.0 UpgradeThank you for this automated dependency update! I've reviewed the changes and have identified several important considerations before this PR can be merged. SummaryThis PR upgrades all Symfony components from Issues Found🚨 Critical: Symfony Flex Configuration MismatchThe "extra": {
"symfony": {
"allow-contrib": "false",
"require": "7.*" // ⚠️ Still set to 7.* but dependencies are now 8.0
}
}Action Required: This should be updated to ❌ Test FailuresThe CI checks show that phpunit tests are failing (3 failed runs). This suggests there are breaking changes in Symfony 8.0 that are incompatible with the current codebase. Action Required:
RecommendationsBefore Merging:
Consider:
Code Quality Assessment
SecurityNo security concerns with the upgrade itself - newer versions generally include security fixes. VerdictDO NOT MERGE until:
This is a significant upgrade that requires careful validation beyond automated dependency updates. |
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
from
83911ee to
83c48c0
Compare
Pull Request Review: Symfony 8.0 UpgradeThis PR upgrades multiple Symfony components from ✅ Positives
|
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
from
83c48c0 to
cec739c
Compare
PR Review: Symfony 8.0 UpgradeThank you for this dependency update! I've conducted a thorough review of the Symfony 7.1 → 8.0 upgrade. Here's my analysis: ✅ Overall AssessmentThis is a major version upgrade from Symfony 7.1 to 8.0. The changes look good, but there are several important items that need attention before merging. 🔴 Critical Issues1. Missing
|
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
from
cec739c to
0528f8c
Compare
PR Review: Symfony 8.0 UpgradeThank you for this dependency update PR! This upgrades most Symfony components from ^7.1 to ^8.0, which is a major version bump. Here's my detailed review: 🔍 OverviewThis PR upgrades 15 Symfony packages to version 8.0, which was released in December 2024. This is generally a good maintenance practice to stay current with security updates and new features. ✅ Positives
|
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
from
0528f8c to
ed3f01a
Compare
Pull Request Review: Symfony 8.0 UpgradeOverviewThis PR upgrades all Symfony dependencies from ^7.1 to ^8.0, which is a major version upgrade. This is an automated PR from Renovate bot. Positive Aspects
Critical Issues1. Conflicting Symfony Flex ConfigurationLocation: composer.json:110-113 The extra.symfony.require field is set to "7.*" but the dependencies are being upgraded to ^8.0: "extra": {
"symfony": {
"allow-contrib": "false",
"require": "7.*" // This conflicts with ^8.0 dependencies!
}
}Impact: Symfony Flex uses this field to constrain which package versions it installs. This mismatch could cause:
Recommendation: Update this to: "require": "8.*"2. PHP Version CompatibilitySymfony 8.0 requires PHP 8.2+ according to the official release notes. The current configuration:
This is acceptable but consider:
Testing RequirementsCRITICAL: This PR requires thorough testing before merge:
Potential Compatibility IssuesBased on the codebase architecture, these areas warrant special attention:
Breaking Changes to MonitorSymfony 8.0 introduced several breaking changes. Key ones to watch:
RecommendationsBefore Merging:
Optional Improvements:
Risk AssessmentRisk Level: MEDIUM-HIGH This is a major version upgrade that requires:
Recommendation: Do not merge until:
Additional Resources
Overall: This upgrade is necessary and beneficial, but requires the configuration fix and thorough testing before it can be safely merged. |
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
from
ed3f01a to
de1fdb7
Compare
Pull Request Review: Symfony 8.0 UpgradeSummaryThis PR upgrades 15 Symfony components from ^7.1 to ^8.0, which is a major version bump. This is a Renovate bot-generated PR that requires careful attention before merging. Critical Issues🔴 BLOCKER: Mixed Symfony VersionsLocation: One critical dependency was missed in this update:
Why this matters: Symfony components are designed to work together at the same major version. Mixing Symfony 7.x and 8.x components can lead to:
Recommendation: Either:
|
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
from
de1fdb7 to
1636533
Compare
Pull Request Review - Symfony 8.0 UpgradeThis PR upgrades all Symfony dependencies from ✅ Positive Aspects
|
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
from
1636533 to
3cf49f8
Compare
Pull Request Review: Symfony 8.0 UpgradeThank you for this automated dependency update from Renovate! I've reviewed the changes to upgrade Symfony components from ^7.1 to ^8.0. Here's my analysis: ✅ Positive Aspects
|
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
from
3cf49f8 to
a7db7fa
Compare
Pull Request Review: Symfony 8.0 UpgradeThank you for this automated dependency update from Renovate. I've conducted a comprehensive review of upgrading from Symfony 7.x to 8.0. Here's my detailed analysis: Summary✅ Overall Assessment: APPROVE with minor recommendations This is a straightforward dependency version bump that updates 16 Symfony packages from Code Quality & Best Practices✅ Strengths
|
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
from
a7db7fa to
a3b9b65
Compare
Pull Request Review: Symfony 8.0 UpgradeThank you for this automated dependency update! I have conducted a thorough review of the changes and their impact on the Phabalicious codebase. Critical Issues1. Incomplete Upgrade - Missing symfony/dependency-injection The PR upgrades 15 Symfony components to ^8.0, but symfony/dependency-injection remains at ^7.1 (line 11 in composer.json). This creates a version mismatch that could cause incompatibility issues and unpredictable DI container behavior. Recommendation: Update symfony/dependency-injection to ^8.0 to match other components. 2. Symfony Flex Configuration Mismatch Lines 110-113 in composer.json specify require: 7.* but the PR upgrades to Symfony 8.0. This tells Symfony Flex to restrict packages to version 7.x, conflicting with the upgrade. Recommendation: Update to require: 8.* or remove this constraint. Moderate Risk Areas3. Custom InputDefinition Subclasses Two custom InputDefinition subclasses override internal Symfony Console methods:
These should be tested thoroughly as they affect command-line argument parsing across all 40+ commands. 4. Compiler Pass Compatibility Two custom compiler passes need verification with symfony/dependency-injection 8.0:
Low Risk Areas (Verified Compatible)
Code Quality IssueFile src/ShellCompletion/UnvalidatedInputDefinition.php line 47 has a typo: AddOption should be addOption (PSR-12 violation, not blocking) Testing RecommendationsBefore merging:
Security & PerformanceNo security concerns. Upgrade includes security fixes from Symfony 8.0.x. Performance improvements expected with better caching and optimized console rendering. Overall AssessmentThis is a MOSTLY GOOD dependency upgrade with TWO CRITICAL BLOCKERS:
Recommendation: DO NOT MERGE as-is. Once these issues are resolved and tests pass, the upgrade should be safe to merge. The codebase follows Symfony best practices and uses stable APIs compatible with version 8.0. |
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
from
a3b9b65 to
72eadfe
Compare
Pull Request Review: Symfony 8.0 UpgradeThis PR upgrades all Symfony components from ^7.1 to ^8.0. Here's my comprehensive analysis: ✅ Overall AssessmentThe upgrade is well-structured and follows Renovate's automated dependency update pattern. The codebase appears largely compatible with Symfony 8.0, but there are two important issues that need attention before merging. 🔴 Critical IssueSymfony Flex Configuration MismatchLocation: "symfony": {
"allow-contrib": "false",
"require": "7.*" // ❌ Still requires Symfony 7.x
}Problem: The Fix Required: "symfony": {
"allow-contrib": "false",
"require": "8.*" // ✅ Should be 8.*
}
|
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
from
72eadfe to
23de9b5
Compare
Pull Request Review: Symfony 8.0 UpgradeOverviewThis PR upgrades all Symfony dependencies from Code Quality & Best Practices ✅Positive aspects:
Critical Issues Found 🔴1. Conflicting Symfony Requirement in The "extra": {
"symfony": {
"allow-contrib": "false",
"require": "7.*" // ⚠️ This conflicts with the ^8.0 upgrade
}
}Impact: This will force Symfony Flex to install 7.x versions, directly conflicting with your Required fix: Update to: "require": "8.*"Potential Breaking Changes
|
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
from
23de9b5 to
39844c3
Compare
Pull Request Review: Symfony 8.0 UpgradeThis PR upgrades all Symfony components from 🔴 Critical Issues1. Conflicting Symfony Version Requirement in composer.jsonLocation: The "extra": {
"symfony": {
"allow-contrib": "false",
"require": "7.*" // ⚠️ Should be "8.*"
}
}Impact: This will cause composer to reject the Symfony 8.0 packages or create dependency resolution conflicts. Fix Required: Update to 2. Test FailuresAll PHPUnit test runs are failing in CI. The failures need to be investigated and resolved before merging. Common causes for Symfony 8.0 upgrade failures include:
|
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
from
39844c3 to
ce2ca8b
Compare
Pull Request Review: Symfony 8.0 UpgradeOverviewThis PR upgrades all Symfony components from ✅ Code Quality & Best PracticesPositive aspects:
|
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
2 times, most recently
from
37ee6cf to
6a72781
Compare
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
6 times, most recently
from
44ec622 to
616ff2a
Compare
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
2 times, most recently
from
ea43c35 to
af193a4
Compare
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
3 times, most recently
from
881bde9 to
fc8cfea
Compare
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
2 times, most recently
from
fcfad30 to
e7e91f6
Compare
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
3 times, most recently
from
1005e41 to
e5c05c1
Compare
renovate
Bot
force-pushed
the
renovate/major-symfony
branch
from
e5c05c1 to
54bc778
Compare
This PR contains the following updates:
^7.1→^8.0^7.1→^8.0^7.1→^8.0^7.1→^8.0^7.1→^8.0^7.1→^8.0^7.1→^8.0^7.1→^8.0^7.1→^8.0^7.1→^8.0^7.1→^8.0^7.1→^8.0^7.1→^8.0^7.1→^8.0^7.1→^8.0^7.1→^8.0Release Notes
symfony/cache (symfony/cache)
v8.0.10Compare Source
Changelog (symfony/cache@v8.0.9...v8.0.10)
v8.0.9Compare Source
Changelog (symfony/cache@v8.0.8...v8.0.9)
v8.0.8Compare Source
Changelog (symfony/cache@v8.0.7...v8.0.8)
Psr16Cache::getMultiple()returningValueWrapperwithTagAwareAdapter(@pcescon)v8.0.7Compare Source
Changelog (symfony/cache@v8.0.6...v8.0.7)
v8.0.6Compare Source
Changelog (symfony/cache@v8.0.5...v8.0.6)
DoctrineDbalAdapter::doSave()in savepoint to prevent transaction poisoning (@lacatoire)v8.0.5Compare Source
Changelog (symfony/cache@v8.0.4...v8.0.5)
v8.0.4Compare Source
Changelog (symfony/cache@v8.0.3...v8.0.4)
v8.0.3Compare Source
Changelog (symfony/cache@v8.0.2...v8.0.3)
ChainAdapter(@nicolas-grekas)v8.0.1Compare Source
Changelog (symfony/cache@v8.0.0...v8.0.1)
v8.0.0Compare Source
v7.4.10Compare Source
Changelog (symfony/cache@v7.4.9...v7.4.10)
v7.4.9Compare Source
Changelog (symfony/cache@v7.4.8...v7.4.9)
v7.4.8Compare Source
Changelog (symfony/cache@v7.4.7...v7.4.8)
Psr16Cache::getMultiple()returningValueWrapperwithTagAwareAdapter(@pcescon)v7.4.7Compare Source
Changelog (symfony/cache@v7.4.6...v7.4.7)
v7.4.6Compare Source
Changelog (symfony/cache@v7.4.5...v7.4.6)
DoctrineDbalAdapter::doSave()in savepoint to prevent transaction poisoning (@lacatoire)v7.4.5Compare Source
Changelog (symfony/cache@v7.4.4...v7.4.5)
v7.4.4Compare Source
Changelog (symfony/cache@v7.4.3...v7.4.4)
v7.4.3Compare Source
Changelog (symfony/cache@v7.4.2...v7.4.3)
ChainAdapter(@nicolas-grekas)v7.4.1Compare Source
Changelog (symfony/cache@v7.4.0...v7.4.1)
v7.4.0Compare Source
v7.3.11Compare Source
Changelog (symfony/cache@v7.3.10...v7.3.11)
v7.3.10Compare Source
Changelog (symfony/cache@v7.3.9...v7.3.10)
v7.3.9Compare Source
Changelog (symfony/cache@v7.3.8...v7.3.9)
ChainAdapter(@nicolas-grekas)v7.3.8Compare Source
Changelog (symfony/cache@v7.3.7...v7.3.8)
CacheDataCollector(@yitznewton)v7.3.6Compare Source
v7.3.5Compare Source
v7.3.4Compare Source
Changelog (symfony/cache@v7.3.3...v7.3.4)
TagAwareAdapterregistrable as a service (@a.dmitryuk)v7.3.2Compare Source
Changelog (symfony/cache@v7.3.1...v7.3.2)
symfony/config (symfony/config)
v8.0.10Compare Source
Changelog (symfony/config@v8.0.9...v8.0.10)
backed-enumin array shapes (@MatTheCat)v8.0.9Compare Source
Changelog (symfony/config@v8.0.6...v8.0.9)
v8.0.8Compare Source
Changelog (symfony/config@v8.0.7...v8.0.8)
v8.0.7Compare Source
Changelog (symfony/config@v8.0.6...v8.0.7)
v8.0.6Compare Source
Changelog (symfony/config@v8.0.5...v8.0.6)
v8.0.4Compare Source
v8.0.3Compare Source
v8.0.1Compare Source
Changelog (symfony/config@v8.0.0...v8.0.1)
v8.0.0Compare Source
v7.4.10Compare Source
Changelog (symfony/config@v7.4.9...v7.4.10)
backed-enumin array shapes (@MatTheCat)v7.4.9Compare Source
Changelog (symfony/config@v7.4.6...v7.4.9)
v7.4.8Compare Source
v7.4.7Compare Source
Changelog (symfony/config@v7.4.6...v7.4.7)
v7.4.6Compare Source
Changelog (symfony/config@v7.4.5...v7.4.6)
v7.4.4Compare Source
Changelog (symfony/config@v7.4.3...v7.4.4)
ParamConfiguratorinParametersConfig(@jack-worman)v7.4.3Compare Source
Changelog (symfony/config@v7.4.2...v7.4.3)
v7.4.1Compare Source
Changelog (symfony/config@v7.4.0...v7.4.1)
v7.4.0Compare Source
Changelog (symfony/config@v7.4.0-RC3...v7.4.0)
v7.3.10Compare Source
Changelog (symfony/config@v7.3.9...v7.3.10)
v7.3.8Compare Source
Changelog (symfony/config@v7.3.7...v7.3.8)
v7.3.6Compare Source
Changelog (symfony/config@v7.3.5...v7.3.6)
v7.3.4Compare Source
Changelog (symfony/config@v7.3.3...v7.3.4)
GlobResourcepattern with trailing slash (@HypeMC)ReflectionClassResourcehash validation (@HypeMC)v7.3.2Compare Source
Changelog (symfony/config@v7.3.1...v7.3.2)
symfony/console (symfony/console)
v8.0.9Compare Source
Changelog (symfony/console@v8.0.8...v8.0.9)
v8.0.8Compare Source
Changelog (symfony/console@v8.0.7...v8.0.8)
v8.0.7Compare Source
Changelog (symfony/console@v8.0.6...v8.0.7)
ApplicationTesterignoringinteractiveandverbosityoptions whenSHELL_VERBOSITYis set (@nicolas-grekas)v8.0.6Compare Source
Changelog (symfony/console@v8.0.5...v8.0.6)
#wrongly considered null in profiler (@chalasr)#(@chalasr)remainingandestimatedplaceholder guards (@yoeunes)v8.0.4Compare Source
Changelog (symfony/symfony@v7.4.4...vv8.0.4)
isRequired()anddefaultValue()(GromNaN)AbstractDoctrineExtension(GromNaN)Request::get()(PierreCapel)getEnvandsetEnvmethods (santysisi)__sleep/wakeup()by__(un)serialize()(nicolas-grekas)TranslatableMessage::__toString()method, usetrans()orgetMessage()instead (nicolas-grekas)!taggedtag, use!tagged_iteratorinstead (nicolas-grekas)Request::sendHeaders()after headers have already been sent (nicolas-grekas)RateLimiterFactory(nicolas-grekas)sizeLimitoption ofAbstractQuery(xabbuh)nullas allowed variables (xabbuh)RememberMeToken::getSecret()(ktherage)ResizeFormListener(OskarStark)EmojiTransliterator(mttsch)TransportFactoryTestCase(mttsch)security.authentication.hide_user_not_foundparameter (xabbuh)ProviderFactoryTestCase(mttsch)CouchbaseBucketAdapter(mttsch)algorithmandkey(OskarStark)Translatorclassfinal(OskarStark)Routerclassfinal(OskarStark)ResizeFormListener::postSetData()methodfinal(OskarStark)#attribute classfinal(OskarStark)escape_charfunctionality fromCsvEncoder(OskarStark)hide_user_not_foundoption (OskarStark)NativeSessionStorage(OskarStark)escapeparameter fromCsvFileLoader(OskarStark)UrlTypedefault protocol (OskarStark)ImportMapConfigReader::splitPackageNameAndFilePath()(mttsch)AdvancedNameConverterInterface(mttsch)ContainerBuilder::getAutoconfiguredAttributes()(GromNaN)#and#attributes (GromNaN)eraseCredentials()from (User|Token)Interface (chalasr)Application::add()methods (HypeMC)Type(mtarld)LazyGhostTraitandLazyProxyTraitin favor of native lazy objects (nicolas-grekas)setDefault(), usesetOptions()instead (yceruto)v8.0.3Compare Source
v8.0.1Compare Source
Changelog (symfony/console@v8.0.0...v8.0.1)
--helpoption when a command is not found (@santysisi)v8.0.0Compare Source
v7.4.9Compare Source
Changelog (symfony/console@v7.4.8...v7.4.9)
v7.4.8[Compare Source](https
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.