fix: Arrow 23.0.0 CURL::libcurl compatibility + CI fixes#1282
Merged
facontidavide merged 4 commits intomainfrom Feb 4, 2026
Merged
fix: Arrow 23.0.0 CURL::libcurl compatibility + CI fixes#1282facontidavide merged 4 commits intomainfrom
facontidavide merged 4 commits intomainfrom
Conversation
The previous commit added libcurl4-openssl-dev but didn't bump the cache version, causing stale caches without the curl dev package to be used. Arrow 23.0.0 requires CURL::libcurl target to exist before loading Arrow CMake config. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Arrow 23.0.0+ declares CURL::libcurl in arrow_static's interface link libraries. CMake requires this target to exist before loading Arrow's config. Adding find_package(CURL) creates the CURL::libcurl target. Co-Authored-By: Claude Opus 4.5 <[email protected]>
The debian workflow was missing cmake in the apt install step. Co-Authored-By: Claude Opus 4.5 <[email protected]>
facontidavide
changed the title
For PRs, github.ref_name is "1282/merge" which creates an invalid Windows path. Replace / with - to create a valid filename. Co-Authored-By: Claude Opus 4.5 <[email protected]>
facontidavide
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CMake error with Arrow 23.0.0:
Changes
find_package(CURL QUIET)beforefind_package(Arrow)to create theCURL::libcurltarget that Arrow 23.0.0 requirescmakepackage to apt installref_nameto replace/with-for valid Windows filename (fixes PR builds)Test plan
🤖 Generated with Claude Code