added texture mode on load_obj

[ashimdahal]

ShapeNetCore throws error texture UV coordinates are outside the range [0,1], this fixes it by clamping it with the clamp texture mode.

[bottler]

I think you need to pass texture_wrap not texture_mode, so you might as well (1) call the new thing texture_wrap and (2) fix the docstring in https://github.com/facebookresearch/pytorch3d/blob/main/pytorch3d/io/obj_io.py#L151-L153 to say texture_wrap instead of texture_mode to avoid this confusion (you can do that in this PR).

And did you actually run the code and see success?

[ashimdahal]

Thanks, I fixed the issues you mentioned, it should run fine now.
best,

[bottler]

"it should run fine now" - please actually check. Does it fix a problem that you have been experiencing - i.e. can you load a model now which you couldn't before? Perhaps you can paste an image of what you now get?

In particular, clamping may not actually do the right thing for any shapenet models.

[bottler]

And while adding a new option is not dangerous, changing the default is. I think you really want a much more restricted change here.

[ashimdahal]

Thanks, sorry about not providing snippets and detailed report on the commit.

The following error was showing up persistently alongside the regular warnings while I was loading the items on the shapenetcore dataset.

Clamping the textures fixed the issue of the texture coordinates in shapenet being outside the range of [0,1].

best,

[bottler]

But we need to know that this is the right fix, and that will take more investigation. I think coordinates might need to wrap around, which might mean we want to use the new multi-map option for TexturesUV.