Skip to content

Fix npm security vulnerabilities in website dependencies (ws, js-yaml) - #540

Closed
talgalili with Copilot wants to merge 5 commits into
mainfrom
copilot/fix-security-issues-yet-again
Closed

Fix npm security vulnerabilities in website dependencies (ws, js-yaml)#540
talgalili with Copilot wants to merge 5 commits into
mainfrom
copilot/fix-security-issues-yet-again

Conversation

Copilot AI commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Several high/moderate severity npm CVEs in website/yarn.lock needed patching. Addressed by adding/updating resolutions entries in website/package.json and regenerating yarn.lock.

Changes

Already covered by existing resolutions (no change needed)

Package Alerts Pinned to
http-proxy-middleware #164, #172 >=2.0.9
webpack-dev-server #166, #184, #185 5.2.4

Out of scope

@babel/core (#160, Low): adding >=7.26.10 caused resolution to jump to 8.0.1 (major breaking change). The advisory DB does not flag the version in use as vulnerable; deferred.

Copilot AI linked an issue Jul 21, 2026 that may be closed by this pull request
@meta-cla meta-cla Bot added the cla signed label Jul 21, 2026
Copilot AI changed the title [WIP] Fix all security issues in dependencies Fix npm security vulnerabilities in website dependencies (ws, js-yaml) Jul 21, 2026
Copilot AI requested a review from talgalili July 21, 2026 10:31
@talgalili
talgalili marked this pull request as ready for review July 21, 2026 10:32
Copilot AI review requested due to automatic review settings July 21, 2026 10:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the documentation website’s Yarn-managed dependency graph to remediate reported npm security advisories by adjusting resolutions and regenerating the lockfile.

Changes:

  • Added a ws resolution to enforce a patched version across transitive consumers.
  • Bumped the js-yaml resolution to a patched 3.x version.
  • Regenerated website/yarn.lock to reflect the updated resolution constraints (including consolidation to ws@8.21.1 and js-yaml@3.15.0).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
website/package.json Updates Yarn resolutions for ws and js-yaml to address advisories.
website/yarn.lock Lockfile refresh to apply the new resolutions and updated transitive versions.

Comment thread website/package.json Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 21, 2026 10:36
@meta-codesync

meta-codesync Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@talgalili has imported this pull request. If you are a Meta employee, you can view this in D113003265.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

Comment thread website/package.json Outdated
Comment on lines +77 to +78
"ws": "^8.21.1",
"js-yaml": "^3.15.0",
Comment thread website/package.json Outdated
Comment on lines +76 to +77
"wait-on": "^7.2.0",
"js-yaml": "^3.14.2",
"ws": "^8.21.1",
Copilot AI requested review from Copilot and removed request for Copilot July 21, 2026 11:32
@facebook-github-tools

Copy link
Copy Markdown

@Copilot has updated the pull request. You must reimport the pull request before landing.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

Comment thread website/package.json
Copilot AI requested review from Copilot and removed request for Copilot July 21, 2026 11:53
@facebook-github-tools

Copy link
Copy Markdown

@Copilot has updated the pull request. You must reimport the pull request before landing.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

website/package.json:79

  • The PR description says the fix is a global ws resolution (">=8.21.0") and a global js-yaml resolution bump, but package.json actually introduces package-scoped resolutions (webpack-dev-server/ws, @docusaurus/core/webpack-bundle-analyzer/ws, gray-matter/js-yaml) and uses ^8.21.1/^3.15.0 ranges. This mismatch makes it hard to verify the intended scope of the security pin (global vs only those transitive paths).
    "webpack-dev-server/ws": "^8.21.1",
    "@docusaurus/core/webpack-bundle-analyzer/ws": "^8.21.1",
    "gray-matter/js-yaml": "^3.15.0",

@meta-codesync meta-codesync Bot closed this in 31cb9b2 Jul 21, 2026
@meta-codesync meta-codesync Bot added the Merged label Jul 21, 2026
@meta-codesync

meta-codesync Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@talgalili merged this pull request in 31cb9b2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Fix all security issues

3 participants