misc: Minor index related code improvement#15878
Open
xiaoxmeng wants to merge 1 commit intofacebookincubator:mainfrom
Open
misc: Minor index related code improvement#15878xiaoxmeng wants to merge 1 commit intofacebookincubator:mainfrom
xiaoxmeng wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
|
@xiaoxmeng has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89942683. |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Dec 31, 2025
…or (facebookincubator#15878) Summary: X-link: facebookincubator/nimble#396 This diff adds support for cluster index bounds filtering to ScanSpec and refactors some index-related code for better organization. * ScanSpec IndexBounds Support (velox/dwio/common/ScanSpec.h): Added setIndexBounds() and indexBounds() methods to enable cluster index filtering on top-level columns The index bounds specify a range of values for index columns that can be used to skip stripes/rows during scanning * Index Constants Refactoring (dwio/nimble/index/IndexConstants.h): Introduced new header file defining kKeyStreamId constant (UINT32_MAX) as a placeholder stream ID for cluster index key streams. This reserved ID ensures no conflicts with regular data streams * StripeIndexGroup Enhancement (dwio/nimble/index/StripeIndexGroup.h): Added streamId() accessor method to StreamIndex class for retrieving the stream ID * IndexWriter Cleanup (dwio/nimble/velox/IndexWriter.cpp): Refactored to use the new kKeyStreamId constant instead of inline std::numeric_limits<offset_size>::max() Reviewed By: Yuhta Differential Revision: D89942683
xiaoxmeng
force-pushed
the
export-D89942683
branch
from
c63c51a to
97a5fd9
Compare
xiaoxmeng
added a commit
to xiaoxmeng/nimble
that referenced
this pull request
Dec 31, 2025
…or (facebookincubator#396) Summary: X-link: facebookincubator/velox#15878 This diff adds support for cluster index bounds filtering to ScanSpec and refactors some index-related code for better organization. * ScanSpec IndexBounds Support (velox/dwio/common/ScanSpec.h): Added setIndexBounds() and indexBounds() methods to enable cluster index filtering on top-level columns The index bounds specify a range of values for index columns that can be used to skip stripes/rows during scanning * Index Constants Refactoring (dwio/nimble/index/IndexConstants.h): Introduced new header file defining kKeyStreamId constant (UINT32_MAX) as a placeholder stream ID for cluster index key streams. This reserved ID ensures no conflicts with regular data streams * StripeIndexGroup Enhancement (dwio/nimble/index/StripeIndexGroup.h): Added streamId() accessor method to StreamIndex class for retrieving the stream ID * IndexWriter Cleanup (dwio/nimble/velox/IndexWriter.cpp): Refactored to use the new kKeyStreamId constant instead of inline std::numeric_limits<offset_size>::max() Reviewed By: Yuhta Differential Revision: D89942683
xiaoxmeng
force-pushed
the
export-D89942683
branch
from
97a5fd9 to
f825217
Compare
duxiao1212
approved these changes
Dec 31, 2025
xiaoxmeng
changed the title
Summary: X-link: facebookincubator/nimble#396 This diff adds support for cluster index bounds filtering to ScanSpec and refactors some index-related code for better organization. * Index Constants Refactoring (dwio/nimble/index/IndexConstants.h): Introduced new header file defining kKeyStreamId constant (UINT32_MAX) as a placeholder stream ID for cluster index key streams. This reserved ID ensures no conflicts with regular data streams * StripeIndexGroup Enhancement (dwio/nimble/index/StripeIndexGroup.h): Added streamId() accessor method to StreamIndex class for retrieving the stream ID * IndexWriter Cleanup (dwio/nimble/velox/IndexWriter.cpp): Refactored to use the new kKeyStreamId constant instead of inline std::numeric_limits<offset_size>::max() Reviewed By: duxiao1212, Yuhta Differential Revision: D89942683
xiaoxmeng
force-pushed
the
export-D89942683
branch
from
f825217 to
c0bfa20
Compare
xiaoxmeng
added a commit
to xiaoxmeng/nimble
that referenced
this pull request
Jan 1, 2026
Summary: X-link: facebookincubator/velox#15878 This diff adds support for cluster index bounds filtering to ScanSpec and refactors some index-related code for better organization. * Index Constants Refactoring (dwio/nimble/index/IndexConstants.h): Introduced new header file defining kKeyStreamId constant (UINT32_MAX) as a placeholder stream ID for cluster index key streams. This reserved ID ensures no conflicts with regular data streams * StripeIndexGroup Enhancement (dwio/nimble/index/StripeIndexGroup.h): Added streamId() accessor method to StreamIndex class for retrieving the stream ID * IndexWriter Cleanup (dwio/nimble/velox/IndexWriter.cpp): Refactored to use the new kKeyStreamId constant instead of inline std::numeric_limits<offset_size>::max() Reviewed By: duxiao1212, Yuhta Differential Revision: D89942683
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds support for cluster index bounds filtering to ScanSpec and refactors some index-related code for better organization.
Added setIndexBounds() and indexBounds() methods to enable cluster index filtering on top-level columns
The index bounds specify a range of values for index columns that can be used to skip stripes/rows during scanning
Introduced new header file defining kKeyStreamId constant (UINT32_MAX) as a placeholder stream ID for cluster index key streams. This reserved ID ensures no conflicts with regular data streams
Added streamId() accessor method to StreamIndex class for retrieving the stream ID
Refactored to use the new kKeyStreamId constant instead of inline std::numeric_limits<offset_size>::max()
Differential Revision: D89942683