fix: Add $SUDO to uv installation commands for proper permissions#15877
fix: Add $SUDO to uv installation commands for proper permissions#15877rdtr wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
The install_uv and uv_install functions install binaries to \$INSTALL_PREFIX/bin (defaults to /usr/local/bin), which requires elevated permissions on non-root systems. This change adds \$SUDO to both functions, consistent with how apt commands are already handled in the setup scripts.
✅ Deploy Preview for meta-velox canceled.
|
|
Hi @rdtr! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
meta-cla
bot
added
the
CLA Signed
1 participant
The
install_uvanduv_installfunctions install binaries to $INSTALL_PREFIX/bin (defaults to /usr/local/bin), which requires elevated permissions on non-root systems.This change adds $SUDO to both functions, consistent with how apt commands are already handled in the setup scripts.
These lines were initially introduced for Docker-based development, where containers run as root and no permission issues occur. This fix addresses the case when running
setup-ubuntu.shdirectly on a Ubuntu host machine as a non-root user.The change is consistent with the existing pattern used for apt commands throughout the setup scripts.
Test plan
./scripts/setup-ubuntu.sh install_build_prerequisiteson Ubuntu 22.04 as non-root user