Skip to content

Conversation

@rzikm
Copy link
Contributor

@rzikm rzikm commented Jan 16, 2026

On newer MSVC compilers, compilation of divsufsort.c causes C4242 warnings.

divsufsort.c(438): error C4242: 'function': conversion from '__int64' to 'int', possible loss of data

This and C4244 are similar warnings which should not be generally suppressed.

This PR fixes those warnings by explicitly casting ptrdiff_t to int via a helper macro.

The alternative is to change certain variable types, but the current approach seemed like less risky change.

@meta-cla meta-cla bot added the CLA Signed label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant