Build all of folly for HHVM OSS rather than patching out bits and pieces#9752
Open
mszabo-wikia wants to merge 1 commit intofacebook:masterfrom
Open
Build all of folly for HHVM OSS rather than patching out bits and pieces#9752mszabo-wikia wants to merge 1 commit intofacebook:masterfrom
mszabo-wikia wants to merge 1 commit intofacebook:masterfrom
Conversation
Currently we patch the folly build system in OSS HHVM to only build a subset. This is generally brittle since the patch needs updating if the upstream listfile changes in an incompatible way. Let's simplify things and build all of folly instead. Add newly required deps and remove dead patches.
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D98722768. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we patch the folly build system in OSS HHVM to only build a subset. This is generally brittle since the patch needs updating if the upstream listfile changes in an incompatible way. Let's simplify things and build all of folly instead.
Add newly required deps and remove dead patches.