Make HPHP_VIXL a public compile definition#9749
Open
mszabo-wikia wants to merge 1 commit intofacebook:masterfrom
Open
Make HPHP_VIXL a public compile definition#9749mszabo-wikia wants to merge 1 commit intofacebook:masterfrom
mszabo-wikia wants to merge 1 commit intofacebook:masterfrom
Conversation
D94756745 came with a new listfile for the vixl update (thanks for that!). Update it to make `HPHP_VIXL` a public compile definition so that targets that consume `vixl` have it defined when including vixl headers, otherwise HHVM-specific compatibility methods will be missing.
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D98721860. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D94756745 came with a new listfile for the vixl update (thanks for that!). Update it to make
HPHP_VIXLa public compile definition so that targets that consumevixlhave it defined when including vixl headers, otherwise HHVM-specific compatibility methods will be missing.