fix defineProperty() proxy hook for array length#1911
Open
farwayer wants to merge 2 commits intofacebook:static_hfrom
Open
fix defineProperty() proxy hook for array length#1911farwayer wants to merge 2 commits intofacebook:static_hfrom
farwayer wants to merge 2 commits intofacebook:static_hfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1910
internalSetter()should be called inJSObject::putNamedWithReceiver_RJS()only if target object is the same as receiver.The lack of check resulted in the Proxy::defineOwnProperty() call being skipped for the array's internal
lengthproperty. This, in turn, resulted in the Proxy'sdefineProperty()hook being ignored.Correct flow by spec for push (and one level proxying Proxy -> Array):
...
Array.prototype.push
// item operations
[[Proxy::Set]](length)
// calling proxy
set()hook or...[[Ordinary::Set]](length, receiver=Proxy)
OrdinarySet(length, receiver=Proxy)
OrdinarySetWithOwnDescriptor(length, receiver=Proxy)
[[Proxy::DefineOwnProperty]](length)
// calling proxy
defineProperty()hook or...[[Array::DefineOwnProperty]](length)
[[Array::ArraySetLength]]
OrdinaryDefineOwnProperty(length)
...
Test Plan
Result before fix:
After: