Skip to content

Update import script to handle Property 1=X name format#25

Open
mathjoh wants to merge 3 commits intofabric-ds:mainfrom
mathjoh:figma_import_2022_08_18
Open

Update import script to handle Property 1=X name format#25
mathjoh wants to merge 3 commits intofabric-ds:mainfrom
mathjoh:figma_import_2022_08_18

Conversation

@mathjoh
Copy link

@mathjoh mathjoh commented Aug 18, 2022

Some icons had a different name format. Instead of Size=x, it was Property 1=X. This PR includes an update to the import script and the icon updates from running a new import.

@pearofducks
Copy link
Contributor

pearofducks commented Aug 18, 2022

I don't think we want to adjust the script and incurr more tech debt and more potential problems with the "contract" between the Figma sheet and this script.

Rather I think the icon sheet just needs adjustment to conform to the established convention?

Starting a quick chat with the icon implementors to see if this is OK with them or if there's some new thing they're doing that we don't know about – will report back!

edit//wrote

Tomi - looks like the bank icon is using some other naming convention or something? Is that easy to adjust on the Figma icon sheet? Or is there something new y'all are doing that we need to fix on the script?
(We see 'property' instead of 'size' for some attributes, and that pisses the script off bad)

@mathjoh
Copy link
Author

mathjoh commented Aug 19, 2022

Updated the PR @pearofducks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants