Add support for scene hierarchy USD importer#2954
Add support for scene hierarchy USD importer#2954Medyan-Naser wants to merge 5 commits intof3d-app:masterfrom
Conversation
|
@mwestphal |
41ff2eb to
05efaf3
Compare
f81b22a to
7a58cfe
Compare
|
\ci fast |
Meakk
left a comment
There was a problem hiding this comment.
LGTM, please fix the style and we'll merge it
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2954 +/- ##
==========================================
- Coverage 97.14% 97.13% -0.01%
==========================================
Files 206 206
Lines 16508 16535 +27
==========================================
+ Hits 16036 16062 +26
- Misses 472 473 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please check why the coverage misses a line. The test is also failing with VTK 9.3, add a CMake condition like other scene hierarchy tests |
Regarding the coverage gap on line 165: this corresponds to |
Describe your changes
Issue ticket number and link if any
closes #2950
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.