-
-
Notifications
You must be signed in to change notification settings - Fork 363
add support for time steps in vtkF3DAssimpImporter #2770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add support for time steps in vtkF3DAssimpImporter #2770
Conversation
|
Hi @mwestphal, I updated new patch, could you help me review it? |
|
\ci fast |
mwestphal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, a small suggestion
96c9b61 to
e3e1edc
Compare
|
\ci full |
plugins/assimp/module/Testing/TestF3DAssimpImporterTimeSteps.cxx
Outdated
Show resolved
Hide resolved
mwestphal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes
|
If CI is clean Ill merge :) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2770 +/- ##
=======================================
Coverage 96.64% 96.64%
=======================================
Files 142 142
Lines 12933 12949 +16
=======================================
+ Hits 12499 12515 +16
Misses 434 434 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks like some lines are not covered, do youb think you can try testing with other files to cover these lines: |
…teps_vtkF3DAssimpImporter
|
there is no need to merge with master |
There are no files in the testing/data directory containing mNumMeshChannels and mNumMorphMeshChannels > 0. It seems I need to create a new file. |
…rter' of https://github.com/cuongdv-20/f3d into support_recovering_keyframes_timesteps_vtkF3DAssimpImporter
Describe your changes
Support to get list of time step in vtkF3DAssimpImporter::GetTemporalInformation
Issue ticket number and link if any
#2735
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.