Skip to content

Export get current animation name#2702

Merged
mwestphal merged 25 commits intof3d-app:masterfrom
iommu:export_getCurrentAnimationName
Jan 9, 2026
Merged

Export get current animation name#2702
mwestphal merged 25 commits intof3d-app:masterfrom
iommu:export_getCurrentAnimationName

Conversation

@iommu
Copy link
Contributor

@iommu iommu commented Dec 9, 2025

Describe your changes

Exported the internal AnimationManager::GetAnimationName as interactor::getAnimationName so that libf3d can access animation name data.

Issue ticket number and link if any

#2699

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes *(see notes)
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings *(see notes)
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Notes:

  • Java bindings do not exist for any interactor code ans so have not been added for this change
  • Python tests do not exist for any interactor animation code (But I would be happy to contribute that if that would be accepted)

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: c, python, java, webassembly.

@iommu
Copy link
Contributor Author

iommu commented Dec 9, 2025

Question regarding the docs : the checklist specifically mentions the QUICKSTART docs. So I'm assuming that, as this feature doesn't really fit being exposed as a CLI option, this doesn't need any changes to that?

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggested API change

@mwestphal
Copy link
Member

Hey @iommu

Need any help moving forward ?

@iommu
Copy link
Contributor Author

iommu commented Dec 23, 2025

Hi, sorry yes I was a bit unsure what you meant by your last comment of
getAnimationName vs availableAnimationNames is that a possible future change or is that something that you would like done for this merge request?

@mwestphal
Copy link
Member

Hi, sorry yes I was a bit unsure what you meant by your last comment of getAnimationName vs availableAnimationNames is that a possible future change or is that something that you would like done for this merge request?

Lets try to do it in this PR :)

@mwestphal
Copy link
Member

Question regarding the docs : the checklist specifically mentions the QUICKSTART docs. So I'm assuming that, as this feature doesn't really fit being exposed as a CLI option, this doesn't need any changes to that?

yes, unrelated to QUICKSTART indeed.

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api change

@iommu iommu requested a review from mwestphal January 7, 2026 09:20
@mwestphal mwestphal marked this pull request as ready for review January 7, 2026 20:44
Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a question

@mwestphal
Copy link
Member

\ci fast

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there, ready for full CI imo :)

@iommu
Copy link
Contributor Author

iommu commented Jan 8, 2026

\ci full

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.64%. Comparing base (6838c62) to head (ffc8ab5).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2702   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files         142      142           
  Lines       12918    12933   +15     
=======================================
+ Hits        12484    12499   +15     
  Misses        434      434           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iommu iommu requested a review from mwestphal January 9, 2026 02:53
@mwestphal mwestphal merged commit 8acb70a into f3d-app:master Jan 9, 2026
74 checks passed
@mwestphal
Copy link
Member

Thanks for the contribution @iommu !

vincenzonetti pushed a commit to vincenzonetti/f3d that referenced this pull request Feb 8, 2026
 - Add `scene::getAnimationName` and `scene::getAnimationNames`
 - Add bindings
 - Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants