Export get current animation name#2702
Conversation
|
You are modifying libf3d public API! |
|
Question regarding the docs : the checklist specifically mentions the QUICKSTART docs. So I'm assuming that, as this feature doesn't really fit being exposed as a CLI option, this doesn't need any changes to that? |
|
Hey @iommu Need any help moving forward ? |
|
Hi, sorry yes I was a bit unsure what you meant by your last comment of |
Lets try to do it in this PR :) |
yes, unrelated to QUICKSTART indeed. |
|
\ci fast |
mwestphal
left a comment
There was a problem hiding this comment.
almost there, ready for full CI imo :)
|
\ci full |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2702 +/- ##
=======================================
Coverage 96.64% 96.64%
=======================================
Files 142 142
Lines 12918 12933 +15
=======================================
+ Hits 12484 12499 +15
Misses 434 434 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the contribution @iommu ! |
- Add `scene::getAnimationName` and `scene::getAnimationNames` - Add bindings - Add tests
Describe your changes
Exported the internal
AnimationManager::GetAnimationNameasinteractor::getAnimationNameso that libf3d can access animation name data.Issue ticket number and link if any
#2699
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampNotes:
Continuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.