Enable instantiating logger with format-string#366
Open
manne65-hd wants to merge 1 commit intof3-factory:masterfrom
Open
Enable instantiating logger with format-string#366manne65-hd wants to merge 1 commit intof3-factory:masterfrom
manne65-hd wants to merge 1 commit intof3-factory:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there @ FatFreeFramework,
let me first say THANK YOU for such a great piece of software!
I am currently working on a "big" cronjob, that uses a lot of logging. As I prefer to use a different format string for date/time, it kind of annoyed me, to add my custom format-string to every write-method-call.
So I gave it a shot and extended the log-class with a feature to instantiate it with a desired format-string that will be used for all subsequent write-method-calls that don't pass a format-string.
As far as I have tested, this retains full backward compatibilty, while just adding the new feature.
If you find it useful, maybe you can merge it.
Thanks again for FatFreeFramework,
Manfred