fix: keep Codex OAuth callback alive - #77
Open
realjoenguyen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The OAuth authorization itself completed, but the browser callback could not reach the app. The app started a loopback listener on localhost:1455, then the Codex login progress window was closed or recreated while the system browser was still completing authentication. The view lifecycle called coordinator.cancel(), which stopped the listener before the browser requested /auth/callback. The browser then showed ERR_CONNECTION_REFUSED.
The original view also owned its own coordinator. If SwiftUI recreated the view, a new PKCE transaction and state could replace the transaction that was already open in the browser. Even if the browser callback arrived later, it could be ignored or fail state validation.
Fix
Security
The manual path never bypasses PKCE or state validation. OAuth codes and tokens are not logged or included in the UI or PR. The callback listener remains bound to the local machine and stops after success, failure, timeout, or cancellation.
Verification