Skip to content

HW5 is completed#5

Open
ezhk wants to merge 7 commits intomasterfrom
hw05_parallel_execution
Open

HW5 is completed#5
ezhk wants to merge 7 commits intomasterfrom
hw05_parallel_execution

Conversation

@ezhk
Copy link
Copy Markdown
Owner

@ezhk ezhk commented Jul 4, 2020

Домашнее задание №5 «Параллельное исполнение»

Критерии оценки

  • Пайплайн зелёный - 4 балла
  • Добавлены новые юнит-тесты - до 4 баллов
  • Понятность и чистота кода - до 2 баллов

Зачёт от 7 баллов

Copy link
Copy Markdown
Collaborator

@Antonboom Antonboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://otus.ru/teacher-lk/homework/23752/7015/

Здравствуйте!
Отличная работа. 1 новый тест - маловато.

Принято
8 / 10


var wg sync.WaitGroup
for _, task := range tasks {
if atomic.LoadInt64(&errorsLeft) < 1 {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: в https://github.com/uber-go/atomic есть API поприятнее


errorsLeft := int64(maxErrors)
concurrentCh := make(chan struct{}, goroutinesLimit)
defer close(concurrentCh)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

зачем?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants