Open
Conversation
added 2 commits
June 12, 2020 09:26
agneum
reviewed
Jun 13, 2020
hw03_frequency_analysis/top.go
Outdated
Comment on lines
+9
to
+10
| var SplitFilter = regexp.MustCompile(`[\s?!.;,]`) | ||
| var IgnoredSymbols = regexp.MustCompile(`[-]`) |
There was a problem hiding this comment.
Переменные можно сделать неэкспортируемыми, поскольку они не используются вне пакета.
Owner
Author
There was a problem hiding this comment.
Поправил в последнем коммите :)
Экспортирование как-то влияет на расход памяти?
There was a problem hiding this comment.
Скорее для инкапсуляции. Чтобы не было желания и возможности редактировать снаружи пакета.
agneum
reviewed
Jun 13, 2020
agneum
previously approved these changes
Jun 13, 2020
agneum
left a comment
agneum
left a comment
There was a problem hiding this comment.
Спасибо за выполненное задание. Отличная работа.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Домашнее задание №3 «Частотный анализ»
Критерии оценки
Зачёт от 7 баллов