Open
Conversation
agneum
reviewed
Aug 24, 2020
Comment on lines
+36
to
+38
| json := jsoniter.ConfigCompatibleWithStandardLibrary | ||
|
|
||
| func getUsers(r io.Reader) (result users, err error) { | ||
| content, err := ioutil.ReadAll(r) | ||
| if err != nil { | ||
| return | ||
| } | ||
| bufReader := bufio.NewReader(r) |
agneum
reviewed
Aug 24, 2020
| result = append(result, user.Email) | ||
| } | ||
|
|
||
| return |
There was a problem hiding this comment.
Предлагаю указать возвращаемые значения в явном виде(не naked return)
agneum
reviewed
Aug 24, 2020
| if err != nil { | ||
| return nil, err | ||
| for _, email := range emails { | ||
| matched := re.MatchString(email) |
There was a problem hiding this comment.
Будет ещё чуть более оптимально, если использовать https://golang.org/pkg/strings/#HasSuffix вместо регулярного выражения
agneum
approved these changes
Aug 24, 2020
agneum
left a comment
agneum
left a comment
There was a problem hiding this comment.
Добрый день! Спасибо за отличную работу.
Итого: 10 баллов из 10.
Статус: принято
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Домашнее задание №10 «Оптимизация программы»
Критерии оценки
Зачёт от 7 баллов