refactor: make nested config structs unexported#419
Merged
soltanoff merged 1 commit intoevrone:masterfrom May 1, 2026
Merged
Conversation
Collaborator
|
Hi! Thanks for your contribution. So please make a rebase and fix the first commit author. 
|
soltanoff
requested changes
May 1, 2026
Collaborator
soltanoff
left a comment
soltanoff
left a comment
There was a problem hiding this comment.
Check the CI pipelines (ignore integration tests errors).
Dawe257
force-pushed
the
refactor/encapsulate-config-types
branch
2 times, most recently
from
6895328 to
a1f5af9
Compare
soltanoff
added
enhancement
Dawe257
force-pushed
the
refactor/encapsulate-config-types
branch
from
a1f5af9 to
5da4151
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, all nested configuration structs are exported, which clutters the package's public API. Since these sub-structs are initialized only via the NewConfig() function within the same package, there is no need for them to be visible to external packages.