Re: experimentalAutoMigrate

[DomThePorcupine]

Hi all,

I'm trying to pick up where PR #259 left off a few months ago. I made some of the requested changes, and was hoping to go over a few of the others in some greater detail.

All the heavy lifting was done by @vmasdani I am just trying to help out to get this change merged :)

Thanks,
Dom

[eveningkid]

Hi Dom,

First of, thank you so much for looking into this :)

I just found some time to review the changes and add extra comments for what I missed in the previous PR.

I know there is a lot, but most changes as you'll see are to keep everything as consistent as possible :)

Another important thing I haven't mentioned: please run deno fmt before committing. It'll apply the coding style used in deno projects.

If you have any questions or opinions on any of the above, do not hesitate to share them!

Have a great holiday!

[eveningkid]

This could be moved upper, right before the for loop (as we'd already know it's not possible)

[eveningkid]

Could we have a more explicit comment here?

As a reference, here's the one for Model.createTable:

/** Create a model in the database. Should not be called from a child model. */

[eveningkid]

I tend to find for in loops more readable, what do you think?

Object.keys(this.fields).map((f) => {
  fieldsToCreate[f] = true;
});

// vs

for (const field in this.fields) {
  fieldsToCreate[field] = true;
}

[eveningkid]

Maybe replace colQuery with columnsQuery as we're using columns on the next line

[eveningkid]

Same as above, for in might be more readable:

for (const existingField in columns[0]) {
  delete fieldsToCreate[existingField];
}

[eveningkid]

This is not necessary

[eveningkid]

Let's rename this to columnName. I think it makes more sense as we use it with columnType

[eveningkid]

This could be combined into one method addColumn because whenever we add a column, we'll set the type:

addColumn(columnName: string, columnType: string) {
  this._query.type = "alter";
  this._query.columnName = columnName;
  this._query.columnType = columnType;
  return this;
}

[eveningkid]

So this will be replaced to:

.addColumn(this.formatFieldToDatabase(field) as string, fieldType.toString())

[eveningkid]

This is not needed I think

[DomThePorcupine]

Hey :)

Thanks so much for taking the time to give me feedback! I've gone through and made the requested changes, as well as adding some new stuff and running deno fmt.

There's a few things I think maybe we should discuss:

• It seems like we rely heavily on dex, but the one in the deno.land third party library links to a github repo that doesn't exist. Perhaps we should consider forking so we can maintain it ourselves?
• I couldn't get the dropColumn function to work, and was going off of the knex docs, I'm not sure if it's because dex didn't implement properly or if there's a bug somewhere ☹️ either way, I'm sorry but if you've got any ideas I'd greatly appreciate it.
• I added a test and noticed that I got a deprecated warning, it seems like the tests are using a v1 style database instantiation. Maybe I can update them at a later time, but what do you think about adding test running and fmt running as github actions or something?

Thanks for all your help!
Dom