Skip to content

Comments

perf(idastar)!: use set for nodes encountered in path#633

Closed
samueltardieu wants to merge 7 commits intomainfrom
push-kkyqttxvmuol
Closed

perf(idastar)!: use set for nodes encountered in path#633
samueltardieu wants to merge 7 commits intomainfrom
push-kkyqttxvmuol

Conversation

@samueltardieu
Copy link
Member

This is a breaking change as it requires the node type to implement Hash

@samueltardieu samueltardieu added enhancement MSRV bump Will be merged later, requires a MSRV bump labels Jan 3, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 3, 2025

CodSpeed Performance Report

Merging #633 will degrade performances by 30.58%

Comparing push-kkyqttxvmuol (8493c73) with main (a4ac532)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 33 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main push-kkyqttxvmuol Change
fill-corner_to_corner_idastar 152.9 µs 220.3 µs -30.58%
fill-no_path_astar 1.5 ms 1.2 ms +32.15%
fill-no_path_dijkstra 1.5 ms 1.1 ms +28.91%

@samueltardieu samueltardieu deleted the push-kkyqttxvmuol branch January 3, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement MSRV bump Will be merged later, requires a MSRV bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant