Skip to content

Comments

Changes to be merged with MSRV 1.82#627

Closed
samueltardieu wants to merge 5 commits intomainfrom
msrv-1.82
Closed

Changes to be merged with MSRV 1.82#627
samueltardieu wants to merge 5 commits intomainfrom
msrv-1.82

Conversation

@samueltardieu
Copy link
Member

@samueltardieu samueltardieu commented Dec 29, 2024

No description provided.

@samueltardieu samueltardieu added the MSRV bump Will be merged later, requires a MSRV bump label Dec 29, 2024
@samueltardieu samueltardieu changed the title Changes for MSRV 1.82 Changes requiring MSRV 1.82 Dec 29, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 29, 2024

CodSpeed Performance Report

Merging #627 will degrade performances by 18.53%

Comparing msrv-1.82 (f94bf47) with main (e5c8bfd)

Summary

❌ 2 regressions
✅ 36 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
corner_to_corner_dijkstra 1.5 ms 1.8 ms -17.68%
no_path_dijkstra 1.4 ms 1.7 ms -18.53%

@samueltardieu samueltardieu changed the title Changes requiring MSRV 1.82 Changes to be merged with MSRV 1.82 Dec 29, 2024
@samueltardieu samueltardieu force-pushed the msrv-1.82 branch 7 times, most recently from e0c6a7f to cd6507f Compare January 3, 2025 21:42
@samueltardieu samueltardieu force-pushed the msrv-1.82 branch 2 times, most recently from f41d414 to 50f995c Compare January 15, 2025 12:42
@samueltardieu samueltardieu force-pushed the msrv-1.82 branch 2 times, most recently from 98c2857 to 1d07594 Compare January 25, 2025 12:19
@samueltardieu samueltardieu force-pushed the msrv-1.82 branch 8 times, most recently from 52bf00d to 9ad22da Compare February 16, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MSRV bump Will be merged later, requires a MSRV bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant