Skip to content

ENG-3617: fix system integration form keys misalignment, make it look more consistent with other forms#8131

Open
nreyes-dev wants to merge 2 commits into
mainfrom
nreyes/eng-3617
Open

ENG-3617: fix system integration form keys misalignment, make it look more consistent with other forms#8131
nreyes-dev wants to merge 2 commits into
mainfrom
nreyes/eng-3617

Conversation

@nreyes-dev
Copy link
Copy Markdown
Contributor

@nreyes-dev nreyes-dev commented May 7, 2026

Ticket ENG-3617

Description Of Changes

The integration form on the system Integrations tab had misaligned field labels: a horizontal layout with a fixed 180px label column produced inconsistent gaps between each label and its input, since label lengths vary. Switched the form to a vertical layout (labels above inputs) to match other admin-ui forms like the Add Integration modal, tightened Form.Item spacing for visual consistency, and fixed a JSX whitespace bug that was rendering the description text as "Amazon S3environment" / "BigQueryenvironment" without a space.

Before

image

After

image

Code Changes

  • Switched <Form> in ConnectorParametersForm.tsx from layout="horizontal" to layout="vertical" and dropped labelCol/labelAlign.
  • Removed the now-unused layout prop and corresponding Form.Item override from FormFieldFromSchema.
  • Applied [&_.ant-form-item]:mb-4 to the <Flex> wrapper in both ConnectorParametersForm and ConfigureIntegrationForm to standardize Form.Item bottom spacing at 16px.
  • Rewrote the description text in ConnectorParameters.tsx as a template literal to preserve the space between the connector name and "environment".

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview May 7, 2026 2:12pm
fides-privacy-center Ignored Ignored May 7, 2026 2:12pm

Request Review

@nreyes-dev nreyes-dev changed the title ENG-3617: fix system integration form keys misalignment ENG-3617: fix system integration form keys misalignment, make it look more consistent with other forms May 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.6% (3042/46035) 5.92% (1572/26518) 4.62% (630/13611)
fides-js Coverage: 78%
79.56% (2028/2549) 66.4% (1259/1896) 73.31% (349/476)
privacy-center Coverage: 85%
82.53% (364/441) 79.74% (189/237) 74.07% (60/81)

@nreyes-dev nreyes-dev marked this pull request as ready for review May 7, 2026 14:24
@nreyes-dev nreyes-dev requested a review from a team as a code owner May 7, 2026 14:24
@nreyes-dev nreyes-dev requested review from kruulik and removed request for a team May 7, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant