relaymonitor: guard DuplicateBidCache with a mutex - #881
Open
damilolaedwards wants to merge 1 commit into
Open
Conversation
Set and Has read and wrote the underlying map with no synchronization. Every configured relay gets its own goroutine calling into the shared cache (one per slot-time offset, plus the consistency coordinator), so concurrent first-inserts into the map were a real race, not just a theoretical one, and could crash the whole process. Added a mutex around the map lookup and creation, and moved cache creation into a single getOrCreateCache helper so there is one place that touches the map under lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set and Has read and wrote the underlying map with no synchronization. Every configured relay gets its own goroutine calling into the shared cache (one per slot time offset, plus the consistency coordinator), so concurrent first inserts into the map were a real race, not just a theoretical one, and could crash the whole process.
Added a mutex around the map lookup and creation, and moved cache creation into a single getOrCreateCache helper so there is one place that touches the map under lock.
Test plan
go build ./...go test ./pkg/relaymonitor/... -race