fix: gsoc and pss checks #557
Open
+81
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| logger.Infof("gsoc: still missing %d chunks: %v. retrying...", len(missing), missing) | ||
|
|
||
| // Retry missing chunks sequentially to avoid flooding | ||
| for _, i := range missing { |
Contributor
There was a problem hiding this comment.
Should the retry loop check ctx.Done() before each iteration?
Without it, cancellation during retry execution won't be detected until all retries complete.
Member
There was a problem hiding this comment.
Yes, there should be a select, with ctx.Done and default directive to pass.
Contributor
| const numChunks = 10 | ||
| func run(ctx context.Context, uploadClient *bee.Client, listenClient *bee.Client, batches []string, logger logging.Logger, parallel bool, numChunks int) error { | ||
| if numChunks <= 0 { | ||
| numChunks = 3 |
Contributor
There was a problem hiding this comment.
Should show a warning to user that we are changing number of chunks to 3 ?
Why 3 exactly ?
Member
There was a problem hiding this comment.
I think that it is ok to return an error here if chunks number is 0 or negative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix GSOC and PSSS checks that fail sometimes