ci: complete migration of docker builds from CircleCI to GitHub Actions #18821
+46
−414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
.github/workflows/tags.yaml
Outdated
| release: | ||
| needs: prep | ||
| uses: ethereum-optimism/factory/.github/workflows/docker.yaml@d04222c229c50320f513afe678b3264869ea11a9 | ||
| uses: ethereum-optimism/factory/.github/workflows/docker.yaml@34a252123f0e19f93e6584f8c73daaf89bce1fc8 |
Contributor
There was a problem hiding this comment.
Inconsistent factory workflow version. The tags.yaml workflow references commit @34a252123f0e19f93e6584f8c73daaf89bce1fc8 while branches.yaml (lines 62 and 107) references @34a2521e4cdb58a81093591adcd959b8647905fe. These are different commits and should be consistent.
Fix: Update to use the same commit hash as branches.yaml:
uses: ethereum-optimism/factory/.github/workflows/docker.yaml@34a2521e4cdb58a81093591adcd959b8647905fe
Suggested change
| uses: ethereum-optimism/factory/.github/workflows/docker.yaml@34a252123f0e19f93e6584f8c73daaf89bce1fc8 | |
| uses: ethereum-optimism/factory/.github/workflows/docker.yaml@34a2521e4cdb58a81093591adcd959b8647905fe |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
falcorocks
force-pushed
the
falco/cci-to-gha-migration-clean
branch
6 times, most recently
from
157f198 to
e4bdcf9
Compare
- Remove docker-build and check-cross-platform jobs from CircleCI - Remove docker-build matrices from main, release, and scheduled-docker-publish workflows - Remove docker-build dependencies from bedrock-go-tests (were gate checks only) - Update GHA branches.yaml: add schedule trigger for daily builds at 2 AM UTC - Update GHA branches.yaml: change registry from 'oss' to 'images' - Update GHA branches.yaml: add check-cross-platform job on ARM runners - Update GHA tags.yaml: change registry from 'oss' to 'images' The check-cross-platform job runs on native ubuntu-24.04-arm runners to verify ARM compatibility of built images, matching the previous CircleCI behavior.
falcorocks
force-pushed
the
falco/cci-to-gha-migration-clean
branch
from
e4bdcf9 to
7a480c7
Compare
- local → build - fork → build-fork
falcorocks
force-pushed
the
falco/cci-to-gha-migration-clean
branch
from
842f85f to
3d6df5d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #18821 +/- ##
==========================================
+ Coverage 75.4% 75.9% +0.4%
==========================================
Files 188 188
Lines 11715 10948 -767
==========================================
- Hits 8839 8311 -528
+ Misses 2730 2493 -237
+ Partials 146 144 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Replicate CCI's contract build process inside Docker: 1. FOUNDRY_PROFILE=ci just packages/contracts-bedrock/forge-build 2. just op-deployer/copy-contract-artifacts 3. just op-deployer/build-go (embeds artifacts) This exactly matches what CCI did, ensuring identical artifacts.
falcorocks
force-pushed
the
falco/cci-to-gha-migration-clean
branch
from
3d6df5d to
1656f37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Docker image builds from CircleCI to GitHub Actions.