Skip to content

Fix:Pads freeze when selecting Italian - #8178

Open
Anshitamiddha wants to merge 1 commit into
ether:developfrom
Anshitamiddha:develop
Open

Fix:Pads freeze when selecting Italian#8178
Anshitamiddha wants to merge 1 commit into
ether:developfrom
Anshitamiddha:develop

Conversation

@Anshitamiddha

Copy link
Copy Markdown

Fix Italian language freeze (#8163)
Problem
Selecting Italian (Italiano) in User Settings caused Etherpad pads to freeze and become unresponsive. Because the language choice is stored in the browser, all pads opened in that browser were affected.
Root cause
The Italian translation for pad.userlist.onlineCount used unsupported localization macro and plural-form names:
"{[ plurale(count) uno: ..., altro: ... ]}"
Etherpad’s localization parser supports the plural macro with one and other forms. The invalid expression was repeatedly processed, resulting in an endless loop.
Changes made
Updated src/locales/it.json:

  • "{[ plurale(count) uno: {{count}} utente connesso, altro: {{count}} utenti connessi ]}"
  • "{[ plural(count) one: {{count}} utente connesso, other: {{count}} utenti connessi ]}"
    Testing
  • Selected Italian in User Settings.
  • Opened and edited a pad.
  • Confirmed the GUI switches to Italian.
  • Confirmed the pad remains responsive and no longer freezes.

Fixes #8163.
Screenshot 2026-08-29 135121

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Fix Italian online-user pluralization freeze

🐞 Bug fix 🕐 Less than 5 minutes

Grey Divider

AI Description

• Corrects the Italian online-user plural macro to use supported localization syntax.
• Prevents pads from freezing after users select Italian.
High-Level Assessment

Correcting the malformed locale expression at its source is the most direct and lowest-risk approach. Parser hardening or locale-wide validation could provide broader defense, but those are separate follow-up improvements rather than better alternatives for this focused fix.

Files changed (1) +1 / -1

Bug fix (1) +1 / -1
it.jsonCorrect Italian online-user plural syntax +1/-1

Correct Italian online-user plural syntax

• Replaces the unsupported Italianized plural macro and form identifiers with the parser-supported 'plural', 'one', and 'other' keywords. This prevents repeated parsing from freezing pads when Italian is selected.

src/locales/it.json

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pads freeze when selecting Italian

2 participants