Refactor - Conform React button and icon button's prop interface#83
Open
echennau wants to merge 1 commit into2.0.1---devfrom
Open
Refactor - Conform React button and icon button's prop interface#83echennau wants to merge 1 commit into2.0.1---devfrom
echennau wants to merge 1 commit into2.0.1---devfrom
Conversation
Now conforms with other components. Also fixed icon button square styling issue.
echennau
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on Terranova, James noted how it was clunky to use certain components (such as the button) since they lacked
classNameand couldn't pass in Tailwind utility classes.PktsButtonandPktsIconButtonnow have a prop interface that conforms with the other components, extending from React'sComponentPropsWithoutRef<"button">, which includes all HTML base attributes. Still provides the ability to discriminate between being a anchor tag or a button tag and having their respective native HTML props.Also fixed icon button square styling issue.