Skip to content

refactor: remove Password field from Costco config, use local costco-go#38

Merged
eshaffer321 merged 1 commit into
mainfrom
refactor/costco-password-field
Jun 22, 2026
Merged

refactor: remove Password field from Costco config, use local costco-go#38
eshaffer321 merged 1 commit into
mainfrom
refactor/costco-password-field

Conversation

@eshaffer321

Copy link
Copy Markdown
Owner

Removes the Password field from Costco config in favor of using the local costco-go library for credential management.

@eshaffer321 eshaffer321 force-pushed the refactor/costco-password-field branch from 196d45f to 70062ca Compare June 22, 2026 02:09
@eshaffer321 eshaffer321 force-pushed the refactor/costco-password-field branch 2 times, most recently from d1677e2 to cae2394 Compare June 22, 2026 02:13
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.73239% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.48%. Comparing base (1bfcad7) to head (cae2394).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/adapters/providers/amazon/provider.go 88.57% 2 Missing and 2 partials ⚠️
internal/infrastructure/config/config.go 93.54% 1 Missing and 1 partial ⚠️
internal/infrastructure/logging/maven_handler.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   58.07%   61.48%   +3.40%     
==========================================
  Files          44       44              
  Lines        4995     5045      +50     
==========================================
+ Hits         2901     3102     +201     
+ Misses       1918     1763     -155     
- Partials      176      180       +4     
Flag Coverage Δ
unittests 61.48% <88.73%> (+3.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/infrastructure/logging/logger.go 75.00% <100.00%> (+75.00%) ⬆️
internal/infrastructure/config/config.go 81.08% <93.54%> (+2.06%) ⬆️
internal/infrastructure/logging/maven_handler.go 80.00% <50.00%> (+80.00%) ⬆️
internal/adapters/providers/amazon/provider.go 73.52% <88.57%> (+32.35%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eshaffer321 eshaffer321 merged commit 68806ec into main Jun 22, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant