[codex] Reuse main TUI surface for BTW#5276
Draft
taibai233 wants to merge 4 commits into
Draft
Conversation
github-actions
Bot
added
tui
added 3 commits
June 29, 2026 09:52
# Conflicts: # internal/boot/boot.go # internal/cli/chat_tui.go # internal/cli/chat_tui_test.go # internal/control/controller.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
BTW had a separate transcript and renderer path, which made it behave very differently from the native main session. Reusing the main surface keeps the UI behavior consistent and removes the duplicate side renderer.
Cache impact
Cache-impact: low - touches agent/boot wiring for BTW side-session rendering, but does not change model cache key construction, prompt text, tool schema generation, history serialization, or cache persistence.
Cache-guard:
GOCACHE=/tmp/go-cache GOMODCACHE=/tmp/go-mod-cache go test -count=1 ./internal/boot -run 'TestBuildWiresSideFactoryAndSink|TestBuildSideAgentHasNoBackgroundJobs'plus./internal/agentfocused tests cover the affected wiring boundaries.System-prompt-review: Codex/taibai233 reviewed boot prompt-sensitive wiring in this PR; the change adds side factory/sink plumbing and tests, with no intended system prompt wording change.
Validation
GOCACHE=/tmp/go-cache GOMODCACHE=/tmp/go-mod-cache make buildGOCACHE=/tmp/go-cache GOMODCACHE=/tmp/go-mod-cache go test -count=1 ./internal/cliGOCACHE=/tmp/go-cache GOMODCACHE=/tmp/go-mod-cache go test -count=1 ./internal/controlGOCACHE=/tmp/go-cache GOMODCACHE=/tmp/go-mod-cache go test -count=1 ./internal/agent -run 'TestPlanMode|TestSideReadOnly'GOCACHE=/tmp/go-cache GOMODCACHE=/tmp/go-mod-cache go test -count=1 ./internal/boot -run 'TestBuildWiresSideFactoryAndSink|TestBuildSideAgentHasNoBackgroundJobs'GOCACHE=/tmp/go-cache GOMODCACHE=/tmp/go-mod-cache go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2 run --timeout=5mgit --no-optional-locks diff --check